Repository navigation
Require the actor's SSH key by default (WARP-1192) - #28
Merged
Merged
Conversation
limit-access-to-actor now defaults to true. If the user who started the workflow has no public SSH key, the step fails instead of opening the session to anyone. Set limit-access-to-actor: false to allow open access. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
priyanka-0206
marked this pull request as ready for review
November 3, 2026 18:52
…WARP-1192) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abhijit-hota
approved these changes
Nov 4, 2026
Member
|
we should release a major version since this is a breaking change. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
If the user who started the workflow had no public SSH key on GitHub, the action opened the debug session to anyone with the connection string. The connection string is in the job log. On a public repository, anyone who can read the log could get a shell on the runner.
Fix
limit-access-to-actornow defaults totrueinstead ofauto.limit-access-to-actor: falseturns the check off.Decisions
limit-access-to-actor: false.autostill works but now behaves liketrue.Testing
npm test: 13 passed. New tests cover a user with a key, a user with no key, andfalse.lib/index.jsrebuilt withnpm run build. A clean rebuild matches it.Manual testworkflow on this branch, onubuntu-24.04:auto: the step fails with the new error and no session starts.true: that key connects and a different key getsPermission denied (publickey). The tmate server logs showRestricting ssh access, num_keys=1,ssh_only=trueand one client.false: the session opens without a key check.Ticket: WARP-1192
🤖 Generated with Claude Code