Skip to content

Require the actor's SSH key by default (WARP-1192) - #28

Merged
priyanka-0206 merged 3 commits into
masterfrom
priyanka-warp-1192
Nov 4, 2026
Merged

priyanka-0206 merged 3 commits into
masterfrom
priyanka-warp-1192

Conversation

@priyanka-0206

@priyanka-0206 priyanka-0206 commented Nov 3, 2026 •

Copy link
Copy Markdown

Issue

If the user who started the workflow had no public SSH key on GitHub, the action opened the debug session to anyone with the connection string. The connection string is in the job log. On a public repository, anyone who can read the log could get a shell on the runner.

Fix

  • limit-access-to-actor now defaults to true instead of auto.
  • If the user has no public SSH key, the step fails with an error that says how to fix it. It no longer opens the session to everyone.
  • Only limit-access-to-actor: false turns the check off.
  • README updated, including that the web shell is off while access is restricted.

Decisions

  • Workflows that used the default, run by a user with no SSH key, will now fail. To fix it, add an SSH key on GitHub or set limit-access-to-actor: false.
  • auto still works but now behaves like true.
  • When access is restricted, tmate turns off the web shell. Users connect by SSH only.

Testing

  • npm test: 13 passed. New tests cover a user with a key, a user with no key, and false.
  • lib/index.js rebuilt with npm run build. A clean rebuild matches it.
  • End to end with the Manual test workflow on this branch, on ubuntu-24.04:
    • No SSH key, auto: the step fails with the new error and no session starts.
    • One SSH key, true: that key connects and a different key gets Permission denied (publickey). The tmate server logs show Restricting ssh access, num_keys=1, ssh_only=true and one client.
    • false: the session opens without a key check.

Ticket: WARP-1192

🤖 Generated with Claude Code

limit-access-to-actor now defaults to true. If the user who started the
workflow has no public SSH key, the step fails instead of opening the
session to anyone. Set limit-access-to-actor: false to allow open access.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 3, 2026

Copy link
Copy Markdown

WARP-1192

@priyanka-0206
priyanka-0206 marked this pull request as ready for review November 3, 2026 18:52
…WARP-1192)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@abhijit-hota

Copy link
Copy Markdown
Member

we should release a major version since this is a breaking change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@priyanka-0206
priyanka-0206 merged commit 693037c into master Nov 4, 2026
1 check passed
@priyanka-0206
priyanka-0206 deleted the priyanka-warp-1192 branch November 4, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants