Repository navigation
Identity link on v1.5: a carried link counts; the Vault is asked from a banner - #1
Merged
Merged
Conversation
…e Vault is asked from a banner After the move to v1.5 the app checked for a link of its key there that it had made itself, so an install whose link was carried from v1.3 or v1.4 asked the Vault for a new one in the background, where the Vault's dialog appeared with no word from ProofPoll. - The check counts a link made on v1.5 or carried there for this key (v1.5 files a carried link only under the two keys its original names), and it must link the key to the identity this install is signed in with. - It runs once this start's agent links are carried (links_carried on the app status), and again on the link poll until the network answers. - When no link is found, a banner asks the person to confirm this device in the Vault; nothing asks the Vault in the background. - Re-linking on a newer network version no longer warns that the previous link could not be revoked: it stays on the older version. - Matrix: an install signed in on v1.3 has no v1.5 link before its move and one after it (carrier leg); an install signed in on v1.5 has its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the move to v1.5 an install whose identity link was carried from v1.3 or v1.4 asked the Vault for a new link in the background. This change:
Matrix: new checks in the carrier leg (an install signed in on v1.3, before and after its move) and the migration leg. Unit test:
the_active_link_counts_for_the_signed_in_identity_only.