Skip to content

fix: handle undefined MessageEvent in postMessageStream #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 1 commit into from
Jul 21, 2026
Merged

fix: handle undefined MessageEvent in postMessageStream #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/jrpc/postMessageStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ import { cloneDeep } from "../utils";
import { BasePostMessageStream, isValidStreamMessage, type PostMessageEvent } from "./basePostMessageStream";

/* istanbul ignore next */
const getSource = Object.getOwnPropertyDescriptor(MessageEvent.prototype, "source")?.get;
const messageEventPrototype = typeof MessageEvent === "undefined" ? undefined : MessageEvent.prototype;

/* istanbul ignore next */
const getOrigin = Object.getOwnPropertyDescriptor(MessageEvent.prototype, "origin")?.get;
const getSource = messageEventPrototype ? Object.getOwnPropertyDescriptor(messageEventPrototype, "source")?.get : undefined;

/* istanbul ignore next */
const getOrigin = messageEventPrototype ? Object.getOwnPropertyDescriptor(messageEventPrototype, "origin")?.get : undefined;

export interface PostMessageStreamArgs extends DuplexOptions {
name: string;
Expand Down
8 changes: 8 additions & 0 deletions test/postMessageStream.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,12 @@ describe("PostMessageStream", () => {
expect(message.target).toBe("auth");
expect(message.data.data.params[0]._origin).toBe("https://current.example");
});

it("can be imported when MessageEvent is undefined", async () => {
vi.unstubAllGlobals();
// Simulate Hermes/React Native where MessageEvent is absent.
Reflect.deleteProperty(globalThis, "MessageEvent");

await expect(import("../src/jrpc")).resolves.toHaveProperty("PostMessageStream");
});
});
Loading