Conversation
shravanrn
changed the title
zherczeg
reviewed
Sep 15, 2026
| static_assert(sizeof(struct wasm_multi_id) <= 1024); | ||
| { | ||
| void *instance_ptr_storage; | ||
| void *instance_ptr_storage = 0; |
Collaborator
There was a problem hiding this comment.
Why setting it 0 instead of instance? Then the line below is unnecessary.
And why 0 instead of NULL or nullptr? I know 0 is accepted, but looks strange.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a case in the tail-call implementation in wasm2c where the
instance_ptris not initialized before being passed to a callee --- on aReturnCallto a non-imported function. As an added defense in depthinstance_ptris explicitly initialized to zero to ensure such bugs would result in an unexploitable crash in the future.