Skip to content

Update features.json in a GitHub Actions workflow - #571

Open
gsnedders wants to merge 4 commits into
WebAssembly:mainfrom
gsnedders:update-features
Open

gsnedders wants to merge 4 commits into
WebAssembly:mainfrom
gsnedders:update-features

Conversation

@gsnedders

Copy link
Copy Markdown

This adds a GitHub Actions workflow, similar to what https://github.com/tc39/dataset does, to keep features.json up-to-date.

This avoids the warnings currently seen on the GitHub Actions, and
migrates to an up-to-date node to match what the actions themselves
use.
This also moves ajv-cli@5 and ajv-formats@2 to be dev dependencies in
package.json, rather than duplicating the manual install from ci.yml.

It also notably currently _does not_ add any new inactive proposals to
features.json; it merely will update inactive proposals that already
are tracked in features.json. This could easily be changed in the
future, but to avoid a much larger diff to features.json, they are
currently omitted.
This means features.json now provides a full machine-readable copy of
the proposals.

@tomayac tomayac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

Let's have a second pair of eyes review this, though, just to be on the safe side. @dschuff maybe?

Comment thread package.json
"scripts": {
"start": "bundle exec jekyll serve",
"prettier": "npx prettier . --write",
"prettier": "prettier . --write",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave npx here, so prettier doesn't have to be globally installed.

@tomayac
tomayac requested a review from dschuff September 22, 2026 07:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants