Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| on: | ||
| pull_request: | ||
| branches: [main, dev] |
There was a problem hiding this comment.
🟡 Merged commits lack release checks
When promotion creates a new main commit, pull_request never checks that SHA. The release gate requires exact-commit results, so releases and deployments remain blocked.
Learn more
The workflow runs for pull requests targeting main and dev, but not for commits created when those PRs merge. A merge or squash creates a new SHA that was never the checked-out commit in the PR run. The promotion gate requires passing checks on the exact commit being released or deployed. Even a green promotion PR therefore cannot supply checks for the resulting main commit.
Example: A promotion PR passes both jobs, then merges as commit abc123 on main. Neither job runs on abc123; the PR's green jobs belong to its pre-merge run, so Azusa cannot release abc123 under the documented gate.
Recommended fix: Add a push trigger for protected branch commits, at least main, and verify that the required check contexts run and pass for the resulting commit before releases or deployments. Keep the PR checks for pre-merge validation.
Was this helpful? React with 👍 or 👎 to provide feedback.
| - name: Check changed Markdown whitespace and required documentation | ||
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| run: | | ||
| git diff --check "$BASE_SHA" HEAD -- '*.md' | ||
| test -s README.md | ||
| test -s docs/SYNTAX.md | ||
| test -s docs/DESIGN.md | ||
| - name: Check documented shell entry points | ||
| run: | | ||
| bash -n tests/run.sh | ||
| bash -n examples/run.sh |
There was a problem hiding this comment.
🔍 Documentation CI does not cover the R0 evidence
Documentation checks validates whitespace, file presence, and shell syntax, but not links or policy consistency. The R0 testing policy calls for relevant link and policy checks; record those separately before treating prose changes as verified.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Align contribution governance with Brad's approved LOG-10 policy and dev/CEO delegations, tracked by Paperclip LOG-19. Feature branches target dev; Yomi reviews the current revision and exact-commit CI remains required.
Changes
Compatibility and risk
Documentation change is R0. No language/runtime, palette, licensing or product behavior changes in this documentation commit.
This PR is stacked on unmerged CI PR 4, and targets dev. Review the documentation commit separately from that dependency; the full base diff still includes its independently reviewed CI work. Do not merge either past its review/control gates.
Independent GitHub approval identity is deferred: shared logbie cannot approve its own PR. Yomi review and protected-branch requirements remain binding. No bypass.
Validation
Documentation commit:
b328ddeecd214b5c47015cca27c1e4bc0e71dc47.Behavior tests N/A — the new commit edits prose and PR guidance only; required Actions are not waived.
Local
git diff --check, changed-Markdown local-path checks and common-policy equality checks passed. Documented shell entry points passed bash -n.External URLs and heading anchors were not network-validated. Actions on this new SHA are pending; no old-head pass is claimed.
Checklist
The owner tracks pending Actions/bot feedback on Paperclip LOG-19 with a scheduled monitor. Main/release/tag/deploy decisions follow GOVERNANCE.md; this PR grants no merge permission.