feat(config): read the HTTP port from .wflcfg - #15
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scriptorium always listened on port 8080 even when a different port was needed. It now reads
web_server_portfrom the local.wflcfg; for example,web_server_port = 9090binds port 9090 after restart. A missing setting or config file keeps the default 8080.Changes
web_server_port = 8080setting and validate whole-number ports from 1 through 65535; empty, malformed, fractional, and out-of-range values fall back to 8080.Compatibility and risk
.wflcfgkey and startup messages. Defaults, bind address, routes, stored data, and Scribe pin remain unchanged.Validation
abf568332d74727e8c1d52ed34c0495b85d1f23d; Windows with WFL 26.9.11 and pinned Scribe93d62af5a6ed6c3ce257ef888107fc3ca1e2dc1d. Blacksmith Ubuntu 24.04 with WFL 26.9.12 and container Python 3.11.2 also passed. The nightly image resolved tobsbyrdwfl/wfl@sha256:7ddc51e6320affa7cfe26263fece590ddbdebe5582659b7e660ca823ed3ddbf1.python scripts/run_tests.py --include-scribepython -m unittest discover -s tests/integration -vpython -m unittest discover -s tests/tooling -vpython scripts/check_repo_hygiene.pygit diff --checkChecklist