Skip to content

fix(admin): label the page and post status selects - #19

Open
logbie wants to merge 2 commits into
devfrom
fix/admin-status-field-label
Open

logbie wants to merge 2 commits into
devfrom
fix/admin-status-field-label

Conversation

@logbie

@logbie logbie commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The new page and post editors show the word Status beside the status select, but the select has no accessible name. page_form.html and post_form.html at 96f4e91cbecf2b6d712e65ffcc2677a5df907ce1 put <span>Status</span> and <select name="status"> inside <div class="field field--inline">.

After this change, both new-editor responses wrap that same text and select in <label class="field field--inline">, matching settings.html. The select name and draft/published options stay. main.wfl is unchanged (SHA-256 5349d813faa1258bdc6d3f929d52baa8d08fc09c7f6c98414941e21ac23db8e1).

Acceptance for this PR: GET /admin/pages/new and GET /admin/posts/new return 200 and the Status text shares one label element with select name="status". Related issue: Logbie LOG-60.

Changes

  • admin/templates/page_form.html and admin/templates/post_form.html: the status field wrapper is a label. Class selectors in admin.css already style .field and .field--inline, and settings already uses this wrapper.
  • tests/integration/editor-labels.test.wfl: HTTP regression for both new-editor routes. It fails when that label wrapper is absent.
  • tests/integration/README.md: documents the suite and the optional older-tree argument.

Role in user_form.html and the file input in _media_panel.html have the same missing association. They are outside this fix.

Compatibility and risk

  • Risk class and reason: R2. Server-rendered admin templates and the new-editor HTTP boundary. No route, schema, auth, or Scribe-pin change.
  • Affected contracts: Admin form markup for /admin/pages/new and /admin/posts/new (the edit routes use the same templates). Public URLs, stored status values, and field names are unchanged.
  • Upgrade and recovery: N/A — template-only. No migration. Rollback is the previous revision.
  • Remaining risks or gaps: Role and media controls stay unlabeled. Browser keyboard, focus, and narrow-screen checks are the Logbie-web admin-design journey, not this HTTP assertion. Workflows on this pin trigger Governance and WFL tests for main pulls and for manual dispatch; a pull request into dev does not start them by itself (open PR fix(ci): run existing checks on dev pull requests #17).

Validation

  • Tested revision and environment: Candidate 40855a686c95a1455c6f4d22cd409956f5d52f87 on fix/admin-status-field-label, parent test commit d7a459dc2509f8e6d65726e313c41a6bcb348cd4, pin 96f4e91cbecf2b6d712e65ffcc2677a5df907ce1. Scribe gitlink remains 93d62af5a6ed6c3ce257ef888107fc3ca1e2dc1d. VM 136/104 red and green output is not recorded yet. This host has no wfl binary and no test-box SSH login.
  • Regression evidence: The test commit keeps the pin template bytes (page_form.html SHA-256 29fb9ec02cae7812310b430f92729af5d3b07f5367756707938b3e2a0f28f47e, post_form.html SHA-256 037a48154a11bf6d0290b05e1944b37d0714b62732870a2ff9e19ae0f7316e70). Intended red is that commit, or the candidate test with the pin tree as the second program argument. Intended green is the candidate commit. Neither command has been executed yet.
Check or exact command Result and evidence
wfl --test tests/integration/editor-labels.test.wfl "$WFL" <pin checkout 96f4e91> from the candidate, on VM 136 or VM 104 Not run — no test-box login on this agent. Expected failure: the inline status label is absent.
wfl --test tests/integration/editor-labels.test.wfl "$WFL" at 40855a686c95a1455c6f4d22cd409956f5d52f87, on VM 136 or VM 104 Not run — same reason. Expected pass.
Governance workflow_dispatch on 40855a686c95a1455c6f4d22cd409956f5d52f87 Passed. Both jobs succeeded, none skipped: Repository checks (ubuntu-latest) and Repository checks (windows-latest). https://github.com/WebFirstLanguage/Scriptorium/actions/runs/36340135033
WFL tests workflow_dispatch on 40855a686c95a1455c6f4d22cd409956f5d52f87 In progress — https://github.com/WebFirstLanguage/Scriptorium/actions/runs/36340133421
Browser bash scripts/test-browser.sh admin-design against Logbie-web 8dc12aa8c5fd037c7bc542e79d55563c5b035740 with SCRIPTORIUM_DIR at this candidate Not run — web adoption stays with Nozomi. This PR does not claim that journey.

Checklist

  • The title, summary, and risk assessment match the final diff.
  • Required validation is recorded above; failures and missing checks are explicit.
  • Documentation, examples, and upgrade/recovery guidance are updated where applicable.
  • I reviewed the diff for repository hygiene, secrets, and private site data.

The validation checkbox stays open until the VM red/green commands and the two workflow runs finish. Missing runs are not passes.

logbie and others added 2 commits September 27, 2026 18:17
GET /admin/pages/new and /admin/posts/new must render Status and the
status select inside one label. This fails while those controls stay
a span plus select inside a div.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Use the settings form's label.field.field--inline wrapper so the visible
Status text names the select. Options, names, and main.wfl stay put.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 08e0f21a-2a7d-4fdb-8bfa-791a7eacb836

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

end action

describe "Editor status labels through HTTP":
test "new page and post status selects sit inside the Status label":

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Regression and UI checks remain unverified

The PR records no Red/Green run or browser checks for the changed forms. Testing policy requires regression evidence and UI checks require keyboard, focus, label, and narrow-screen verification before merge.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant