Conversation
GET /admin/pages/new and /admin/posts/new must render Status and the status select inside one label. This fails while those controls stay a span plus select inside a div. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Use the settings form's label.field.field--inline wrapper so the visible Status text names the select. Options, names, and main.wfl stay put. Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| end action | ||
|
|
||
| describe "Editor status labels through HTTP": | ||
| test "new page and post status selects sit inside the Status label": |
There was a problem hiding this comment.
🔍 Regression and UI checks remain unverified
The PR records no Red/Green run or browser checks for the changed forms. Testing policy requires regression evidence and UI checks require keyboard, focus, label, and narrow-screen verification before merge.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
The new page and post editors show the word Status beside the status select, but the select has no accessible name.
page_form.htmlandpost_form.htmlat96f4e91cbecf2b6d712e65ffcc2677a5df907ce1put<span>Status</span>and<select name="status">inside<div class="field field--inline">.After this change, both new-editor responses wrap that same text and select in
<label class="field field--inline">, matchingsettings.html. The select name and draft/published options stay.main.wflis unchanged (SHA-2565349d813faa1258bdc6d3f929d52baa8d08fc09c7f6c98414941e21ac23db8e1).Acceptance for this PR:
GET /admin/pages/newandGET /admin/posts/newreturn 200 and the Status text shares one label element withselect name="status". Related issue: Logbie LOG-60.Changes
admin/templates/page_form.htmlandadmin/templates/post_form.html: the status field wrapper is a label. Class selectors inadmin.cssalready style.fieldand.field--inline, and settings already uses this wrapper.tests/integration/editor-labels.test.wfl: HTTP regression for both new-editor routes. It fails when that label wrapper is absent.tests/integration/README.md: documents the suite and the optional older-tree argument.Role in
user_form.htmland the file input in_media_panel.htmlhave the same missing association. They are outside this fix.Compatibility and risk
/admin/pages/newand/admin/posts/new(the edit routes use the same templates). Public URLs, stored status values, and field names are unchanged.admin-designjourney, not this HTTP assertion. Workflows on this pin trigger Governance and WFL tests formainpulls and for manual dispatch; a pull request intodevdoes not start them by itself (open PR fix(ci): run existing checks on dev pull requests #17).Validation
40855a686c95a1455c6f4d22cd409956f5d52f87onfix/admin-status-field-label, parent test commitd7a459dc2509f8e6d65726e313c41a6bcb348cd4, pin96f4e91cbecf2b6d712e65ffcc2677a5df907ce1. Scribe gitlink remains93d62af5a6ed6c3ce257ef888107fc3ca1e2dc1d. VM 136/104 red and green output is not recorded yet. This host has nowflbinary and no test-box SSH login.page_form.htmlSHA-25629fb9ec02cae7812310b430f92729af5d3b07f5367756707938b3e2a0f28f47e,post_form.htmlSHA-256037a48154a11bf6d0290b05e1944b37d0714b62732870a2ff9e19ae0f7316e70). Intended red is that commit, or the candidate test with the pin tree as the second program argument. Intended green is the candidate commit. Neither command has been executed yet.wfl --test tests/integration/editor-labels.test.wfl "$WFL" <pin checkout 96f4e91>from the candidate, on VM 136 or VM 104wfl --test tests/integration/editor-labels.test.wfl "$WFL"at40855a686c95a1455c6f4d22cd409956f5d52f87, on VM 136 or VM 10440855a686c95a1455c6f4d22cd409956f5d52f8740855a686c95a1455c6f4d22cd409956f5d52f87bash scripts/test-browser.sh admin-designagainst Logbie-web8dc12aa8c5fd037c7bc542e79d55563c5b035740withSCRIPTORIUM_DIRat this candidateChecklist
The validation checkbox stays open until the VM red/green commands and the two workflow runs finish. Missing runs are not passes.