Conversation
Add RFC 8032 and fail-closed tests for ed25519_verify before the runtime builtin exists. Record the Red cargo-test result (Undefined variable 'ed25519_verify') and the resolved signing contract for later activation work. Co-authored-by: logbie <logbie@users.noreply.github.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Introduce ed25519_verify of public_key and message and signature, implemented with ed25519-dalek against RFC 8032. Hex keys and signatures, UTF-8 message bytes, fail-closed malformed input, and a 1 MiB message cap. Existing HMAC licensing is unchanged. Co-authored-by: logbie <logbie@users.noreply.github.com>
Note that official website CI still ships WFL 26.9.16, and record the HMAC license/checkout suites plus the website-shaped verifier call run against this branch's release binary. Co-authored-by: logbie <logbie@users.noreply.github.com>
Note the pushed-revision GitHub Actions run for f85745a, including Linux and Windows integration and fuzz compile. Co-authored-by: logbie <logbie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small WFL public-key verifier so the Logbie website can later activate licences offline, without changing current HMAC licensing.
Why
The website’s existing keys are
LOGBIE-<id>-<HMAC-SHA256>. That path stays online and secret-keyed. Future activation needs RFC 8032 Ed25519 verification in the same runtime the site already runs. WFL had no public-key primitive.Contract
Resolved in
Engineering/designs/2026-09-21-ed25519-verify.mdbefore the implementation:ed25519-dalek2.2ed25519_verify of public_key and message and signature→yes/noTest evidence
98f6d5ab;cargo test --test crypto_ed25519_verify_testfailed withUndefined variable 'ed25519_verify'(8 failed / 9 passed). Record:Engineering/evidence/2026-09-21-ed25519-verify-red.mdcargo test --lib builtins::tests— 4 passedcrypto_ed25519_verify_test18 passed; new-builtin compatibility 19 passed; existingsha256/hmac_sha2569 passedtarget/release/wfl --test TestPrograms/crypto_ed25519_verify_test.wfl— 7 passed, exit 0;TestPrograms/crypto_standard_test.wflstill 7/0license_test.wfl(8/8) andcheckout_test.wfl(6/6) plus a website-shaped verifier call (1/1) against this release binary. Fullwebsite/scripts/test.sh(Scriptorium smoke) was not run —LogbieLLC/logbieis private and not in this environmentf85745a6; run 35575701421 — 18 successful, 0 failed, 1 skipped (version bump). Linux and Windows integration, fuzz compile, hygiene, fmt/clippy/test, and bothRun WFL Programsmatrices passed. Current headba6ee0abonly adds that CI record.SECURITY_SENSITIVE_BUILTINSincludesed25519_verifyaf82is not valid UTF-8tests/ed25519_verify_test.wfltoscripts/test.sh. This PR does not change licence issue/validate or checkout.Scope
Verification prerequisite only. No activation workflow, no signing API, no HMAC licence changes.
Head:
ba6ee0ab.