Conversation
Without the etr debug flag the error record has no 'data' cell, so hiding the trace failed with "Column 'DATA' does not exist" and the request became a 500. Fixes #11
Move emsdk out of /opt/wh See merge request webhare-opensource/platform!3302
(cherry picked from commit caf43a0741c7954c4eb178d174d2f93db1c60565) Co-authored-by: Rob Hulswit <rob@webhare.nl>
Fix JSON-RPC RPCInvalidArgsException crashing the transport without etr See merge request webhare-opensource/platform!3303
Fix exceptions breaking event callback serializer See merge request webhare-opensource/platform!3305
Feature/whfs index fixes See merge request webhare-opensource/platform!3304
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+21
to
+31
| name: Build Docker | ||
| # See https://github.com/actions/runner-images | ||
| runs-on: ubuntu-26.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| - name: Build Docker in devcontainer | ||
| run: addons/tests/test-devcontainer-builddocker.sh | ||
|
|
||
| make-install: |
Comment on lines
+32
to
+40
| name: Make install | ||
| # See https://github.com/actions/runner-images | ||
| runs-on: ubuntu-26.04 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| - name: Run make install in devcontainer | ||
| run: addons/tests/test-devcontainer-make-install.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@WebHare/reviewers point of discussion: can we still do some sort of smoke test (a full CI seems like too much) after wh builddocker/wh make install to somewhat test the final product? right now the only (implicidt) check is 'did not return an error code'