WIP: Populate linked venue on the gig feed (gig↔venue linkage)#245
Draft
JoshuaVSherman wants to merge 2 commits into
Draft
WIP: Populate linked venue on the gig feed (gig↔venue linkage)#245JoshuaVSherman wants to merge 2 commits into
JoshuaVSherman wants to merge 2 commits into
Conversation
Preserves working-tree changes that were left uncommitted on `dev` since 2026-07-17 (no branch/issue/PR). Adds a `venueId` ObjectId ref to the gig schema plus a minimal Venue model, and makes gig find/findSort populate the linked venue's name/city/usState/website so the SocketCluster gig feed can carry venue details. Relates to the gig↔venue linkage effort (JaM#1220 render-time venue link, JaM#1242 Gigs Location column). INCOMPLETE for the current design: the venue schema here lacks a street `address` field that JaM#1242 needs. Not reviewed, not tested, no issue yet — parked pending decision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP — rescued from orphaned working-tree changes; not finished. Parks the gig↔venue feed-populate work so it's tracked and durable (issue #244).
venueId(ObjectId,ref: 'Venue') field to the gig schema, plus a minimalVenuemodel so the ref resolves.find/findSort.populate()the linked venue'sname/city/usState/website, so the SocketCluster gig feed carries live venue details.Known-incomplete (remaining on #244, for the Sonnet lane):
max-lenerrors ingig-facade.ts(the WIP's single-linetry/catchbodies exceed 150 chars). Fullnpm testfails at eslint until fixed.addressfield that JaM#1242 (Gigs Location column) needs — add it and include it in the populate.find/findSortoverrides.Closes #244
How to test locally
This is WIP — the suite is not fully green yet (lint red). Vitest unit tests pass; eslint does not.
Run the unit tests:
Expect: all unit tests pass (they do — see Test evidence).
Run the full gate (currently RED, by design until the lint fix on #244):
npm testExpect: eslint reports 2
max-lenerrors insrc/model/gig/gig-facade.ts.Exercise the change (once finished): with a gig whose
venueIdpoints at avenuesdocument, the gig model'sfind/findSortnow return that gig withvenueIdpopulated as a subdocument carryingname,city,usState,website— instead of a bare ObjectId. Confirm by loading a linked gig through the gig controller and asserting the populated venue fields are present on the response.Test evidence
🤖 Work by Claude Code — Opus 4.8