fix: Compound assignments for rvalued variables and null deref - #248
Merged
Conversation
Even though the assignment operator is now supported for rvalued variables compound assignment still resulted on parser errors. This PR aims at adding full support of all compound assignments to rvalued variables. The previous implementation of assignment for rvalues was left intact and a new set of functions were added to integrate rvalues with the existing lvalues compound assignment support.
parent and this keywords were not being detected even when they can be used. parent can be assigned to in function statements too. Added a system to select which keywords can be used during detection to generate compiler errors when possible. Many thanks to @majocane in discord for reporting the missing operations and help debugging and figuring thinks out.
…nmentOperator() from propegating upwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the assignment operator is now supported for rvalued variables compound assignment still resulted on parser errors. This PR aims at adding full support of all compound assignments to rvalued variables. The previous implementation of assignment for rvalues was left intact and a new set of functions were added to integrate rvalues with the existing lvalues compound assignment support.
Checks for null pointers and null expressions were also added to the parser implementation. errorCollector was also modified so its state gets reset alongside the parser in case a predicate function fails to parse.