Repository navigation
Make nightly CI fail visibly and keep one publish path - #1
Merged
Merged
Conversation
Release review 2026-10-24 found two CI problems shared by all SDK repos: - nightly.yml used continue-on-error, "|| true" and "|| echo", so a broken install or failing test suite still produced a green run. - publish.yml (release published) and release.yml (v* tag) could both try to upload the same version. Only publish.yml is registered as a PyPI Trusted Publisher; release.yml uploads failed with invalid-publisher. Nightly now upgrades all dependencies eagerly, runs pip check and fails on test failures. release.yml is removed; publish.yml is the single path and is gated on tests.yml (now reusable via workflow_call), a tag/version match and twine check --strict. No package code or version change. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI-only change from the 2026-10-24 release review. No package code or version change, so no PyPI release is needed for this repo.
continue-on-error: true,pip install ... || true,pip install -e .[test] 2>/dev/null || pip install -e .andpytest ... || echo. Nightly now runspip install --upgrade --upgrade-strategy eager -e ".[test]",pip check,pip freezeandpytest tests/ -von Python 3.12.release.yml(v* tag). Run history shows it failed withinvalid-publisherbecause PyPI Trusted Publishing is registered forpublish.yml, whilepublish.ymlfailed with400 File already existswhen both fired for the same tag.publish.ymlnow: reusabletests.ymlgate → tagvX.Y.Zmust equal the pyproject version (on release events) →python -m build+twine check --strict→ OIDC upload in thepypienvironment. The file name and environment are unchanged, so the existing Trusted Publisher keeps working.tests.ymlgains aworkflow_calltrigger so the publish workflow can reuse it.Test plan
actionlintpasses on all workflowsGenerated with Devin