Preserve repository evidence links in suggestions (#5345) - #5355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving an audit suggestion could replace
artifacts/full-dogfood-20260912/FINDINGS.mdwith[REDACTED:high_entropy_token], permanently losing the evidence link. A bounded lexical recognizer now preserves ordinary relative file references, including the original Markdown fragment, through persistence, show, and JSON/Markdown/issue-draft export.The exception checks complete token boundaries, individual path components, and credential context. Credential redaction runs first, including complete quoted, concatenated, and collection-valued credentials. Opaque components, traversal, absolute paths, URLs, and control-bearing paths do not qualify; enclosing-token checks reject URL/rooted-path suffixes while handling separate quoted JSON evidence values independently. YAML blocks, tags, and anchors after credential names conservatively redact the remainder of that bounded text field. Existing identifier regression controls from #4403 and #4751 remain covered. Previously redacted editable drafts can be repaired only by explicitly supplying the original context through the existing update command, retaining their stable ID.
Validation:
Updated both language sections of
USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.md. Addedchangelog.d/unreleased/5345.fixed.md; no directCHANGELOG.mdor agent-instruction changes.Fixes #5345