Explain and safely narrow C# incremental update expansion - #5358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small C# scoped refreshes could re-extract nearly every C# file because static-interface and member-reference contracts required workspace expansion. This change explains that work and narrows re-extraction only when complete source-input evidence proves the workspace lookup inputs unchanged.
Fixes #5347
Changes
csharp_workspace_expansiondiagnostics with the trigger, decision, original/expanded/final target counts, and preflight phase costs. Successful CLI updates and persisted CLI/MCP status share the same object; configuration-driven full scans identify their fallback.Validation
make lintpassed after formatting two C# files; the Release test-project build passed with zero warnings/errors, and the affected metadata regression passed on both .NET 8 and .NET 9. This follow-up changes whitespace only.git diff --checkpassed.Documentation
docs/csharp-update-expansion.md, with English/Japanese developer/testing-guide updates.changelog.d/unreleased/5347.changed.md;CHANGELOG.mdis unchanged.AGENT_GUIDE.mdupdates the shared status contract. No agent entry-point files were changed.Review and scope
Two Codex adversarial passes identified project-marker proof, case-only rename diagnostics, quiet-output behavior, and a follow-up marker-scan race. All findings were fixed with behavioral regressions. The final race/budget cases fail before the fix and pass afterward, with conservative/full extraction controls. Review followed the repository's two-round limit; the final fix was verified by tests. Final root/manifest freshness and completeness checks passed at the committed HEAD, and immediate/persisted expansion diagnostics matched. Only #5347 is in scope; no unrelated follow-up issue was identified.