Resume bounded C# origin classification (#5348) - #5359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large indexed C# files can exhaust the origin-classification prefix while regex scanning completes. Add explicit
--origin-passes(1–16, default 1) to search, audit and regex find so successive windows carry the shared lexical state forward. Each pass classifies at most 4,096 new lines and reads at most 8 Mi characters and 128 chunks, including overlap. Generation changes or conflicting overlap discard provisional state; missing or malformed context remains unknown. Find diagnostics distinguish exhausted budgets and give bounded retry guidance, with pass settings bound to cursor and recipe replay.The original 6,299-line reproduction changes from 243 code / 111 unknown occurrences and exit 11 to 353 code / 0 unknown with two passes and authoritative completion. The remaining occurrence is non-code. The same counts and exit statuses were also verified against the indexed 6,305-line version of the fixture.
Validation:
origin/main(f0889b95b): 344 targeted Release tests passed on each of net8.0 and net9.0, including shared classification, continuation, help, completion and the incoming C# workspace expansion fixtures. The new boundary regression was confirmed failing before the fix; matching-overlap and completed-interpolation controls also pass.make lint, bilingual fragment validation andgit diff --checkpassed. The CI whitespace failure in the continuation test initializers is fixed.No blocking/actionable issues found.Updated the English/Japanese user, developer, testing and find-control documentation. Changelog fragment:
changelog.d/unreleased/5348.fixed.md. No changes to agent instruction files orCHANGELOG.md.Fixes #5348
Follow-up: #5357.