feat: reorder bookmarks and folders via drag-and-drop - #59
Merged
Conversation
Adds an explicit `order` field to Bookmark/BookmarkFolder and wires BookmarksTreeProvider up as a vscode.TreeDragAndDropController so users can drag to reorder bookmarks within a folder/list, reorder folders, and drag a bookmark onto a folder to move it. Items sort by `order` when set, falling back to the existing createdAt/name ordering for anything not yet touched by a drag. Closes #38
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orderfield toBookmark/BookmarkFolderand asortByOrderhelper that sorts by it when set, falling back to the existingcreatedAt/name ordering for anything not yet touched by a drag.BookmarksTreeProviderup as avscode.TreeDragAndDropController(registered viadragAndDropControlleroncreateTreeView) to support:folderId; tree view reassignsfolderIdwhen a bookmark is dropped across folders.Closes #38
Test plan
npm run lintnpm run test:coverage— 100% statements/lines, 94.11% branchesnpm run buildscripts/local-patch-report.sh— 100% patch coverage (69/69)