Skip to content

test(git): cover regular-to-symlink provenance - #73

Merged
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-21-symlink-type-transition-provenance
Sep 30, 2026
Merged

nia-sg-bot merged 1 commit into
mainfrom
nia/issue-21-symlink-type-transition-provenance

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add a deterministic regression covering a regular-file → symlink type transition
  • verify exact pre/post paths, modes, and immutable blob IDs for unstaged, staged, and two-dot commit-range resolution
  • prove symlink identity is the raw target blob, not a clean-filtered file artifact

Part of #21.

Validation

  • python3 -m pytest -q (204 passed)
  • python3 -m compileall -q diffgraph tests
  • python3 -m diffgraph.cli --help
  • git diff --check origin/main...HEAD

Compatibility

No production CLI or schema behavior changes. This locks in the existing versioned snapshot-provenance contract used by downstream consumers.

Remaining work

Issue #21 retains its broader comparison-mode and resolver edge-case acceptance criteria.

Summary by CodeRabbit

  • Tests
    • Added coverage for detecting file-to-symlink changes, including their status, modes, and blob IDs across unstaged, staged, and commit-range resolutions.

@nia-sg-bot nia-sg-bot added roadmap Tracked on the public WildestAI roadmap priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction labels Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 84ec9b80-1da8-4ef3-871b-8ac09a90027f

📥 Commits

Reviewing files that changed from the base of the PR and between 773e1d0 and baf4da5.

📒 Files selected for processing (1)
  • tests/test_git_snapshot.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Adds test coverage for regular-file-to-symlink transitions in unstaged, staged, and commit-range snapshots. The tests check the type-change status, endpoint modes, and blob identities.

Changes

Snapshot provenance tests

Layer / File(s) Summary
Verify type-change provenance
tests/test_git_snapshot.py
Adds assertions for unstaged status T, modes 100644 and 120000, and blob identities. It checks that staged and commit-range resolution match the preceding snapshot entries.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to baf4d

This test-only change strengthens symlink provenance coverage without changing production behavior. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the added Git test for regular-file-to-symlink provenance. It matches the main change in the pull request.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nia-sg-bot
nia-sg-bot merged commit 864a3de into main Sep 30, 2026
4 checks passed
@nia-sg-bot
nia-sg-bot deleted the nia/issue-21-symlink-type-transition-provenance branch September 30, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction priority:P0 Critical path / blocks a usable product roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant