Repository navigation
feat(api): react to comments with emoji (#362) - #364
Merged
Merged
Conversation
Lets users acknowledge a comment (e.g. after an @mention) without writing
a reply.
- comment_reactions persistence: migration plus fresh-install schema for
SQLite and PostgreSQL, unique per comment, user, and reaction; rows
cascade with the comment and the user.
- Fixed reaction set: thumbs_up, check, eyes, heart, laugh, hooray.
- API v2: POST /comments/{comment_id}/reactions and
DELETE /comments/{comment_id}/reactions/{reaction}, both idempotent and
gated like commenting (comment read + item.comment). Comment list, get,
update, and batch responses carry grouped reactions; approval rows never do.
- Live update: reactions publish an item change so open views reconcile.
- UI: reaction chips under each comment (own reaction highlighted, click
toggles, tooltip lists who reacted) and a picker; strings for en, de, fr,
ru, zh-CN.
Contributed by @dpb97 in #362.
stefan-ernst
changed the title
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #362 into
mainand reworks it to fit this repository's rules. Lets users acknowledge a comment (e.g. after an @mention) without writing a reply.Changes carried over from #362:
comment_reactionspersistence: migration plus fresh-install schema for SQLite and PostgreSQL, unique per comment, user, and reaction; rows cascade with the comment and the user.thumbs_up,check,eyes,heart,laugh,hooray.POST /comments/{comment_id}/reactionsandDELETE /comments/{comment_id}/reactions/{reaction}, both idempotent and gated like commenting (comment read +item.comment). Comment list, get, update, and batch responses carry grouped reactions; approval rows never do.Adjustments made while landing it:
data-testidto the reaction picker options so the UI test can select them without role or text matching.release.shnow lists the same 1.27.3 base images for provenance.Test plan:
go build ./...,gofmt,golangci-lint runon the touched packages.make-equivalent pre-commit guards: schema/migration pairing, SQL boolean literals, handler DB access, layering, OpenAPI v2 metadata/generate/parity, frontend v2 field guard, i18n, design tokens, HMR boundaries,svelte-check.../core-tests/overlay.sh . -- -tags=test -count=1 -run Comment ./internal/services/ ./tests/on SQLite and PostgreSQL.../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/items/Comments.test.js src/lib/features/items/CommentReactions.test.js.