Repository navigation
WI-1799: Honor OpenRouter reasoning settings on Chat Completions requests - #369
windshiftsite[bot] wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA windshift-agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
Closing in favor of a re-scoped WI-1799. The design direction changed after review. Instead of a closed, provider-specific reasoning schema with strict validation, Windshift will:
Consequently the strict reasoning validation introduced here (unknown-subfield rejection, protocol-incompatible rejection) and the provider-specific WI-1799 has been re-scoped accordingly. Wire-level tests remain a requirement and were missing here. |
Implemented WI-1799. Chat Completions now translates normalized reasoning effort and enabled=false/true into the provider-native reasoning object, while private controls remain excluded from generic passthrough. Validation now rejects unknown reasoning fields and protocol-incompatible summary/budget/enabled settings instead of silently dropping them; Responses and Anthropic paths reject enabled explicitly. Committed as 16be5d8. Runtime tests could not be executed because the Go toolchain is unavailable in the container; git diff --check passed.
Opened by the Windshift coding-agent harness.
Run id: 158
Base commit: ecff5a7
Branch: agent-runs/run-158