Repository navigation
Remove the authenticated app footer - #377
sprouty-io wants to merge 3 commits into
Conversation
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
2c1f012 to
2915f65
Compare
The pinned footer reserved a strip at the bottom of every authenticated page. Move it into the page content so it is only reached by scrolling, and only on document surfaces. Builds on the footer removal in Windshiftapp#377 by @sprouty-io, which identified that the pinned footer wasted vertical space. The About, API Reference, Licenses, and report-problem links stay in the footer. - add MAIN_APP_FOOTER_VIEWS and place the footer per route wrapper in MainRouteContent - pin the footer to the bottom of short pages with mt-auto - hide it in review focus mode and on viewport-filling surfaces - add stable data-testids to the footer and its links
|
Picked this up and extended it into a full relocation, since the branch now moves the footer rather than dropping it. The pinned footer reserved a strip at the bottom of every authenticated page. This moves it into the page content so it is only reached by scrolling, and only on document surfaces. Builds on @sprouty-io's footer removal here, which identified that the pinned footer wasted vertical space. The About, API Reference, Licenses, and report-problem links stay in the footer.
Validation:
|
The pinned footer reserved a strip at the bottom of every authenticated page. Move it into page content so it is only reached by scrolling, and only on document surfaces; viewport-filling surfaces (boards, canvases, Svelte Flow designers) keep no footer. MAIN_APP_FOOTER_VIEWS and isMainAppFooterView() gate the placement per route. MainRouteContent renders the footer after the route resolves (never during loading, on error, or in review focus mode), and mt-auto pins it to the bottom of short pages. Builds on the footer removal by @sprouty-io in #377.
|
Superseded by 22c0122 on The change is credited to @sprouty-io, whose commit here first identified that the pinned footer wasted vertical space. It lands as a maintainer-authored commit rather than a merge of this branch because @sprouty-io's commit is unsigned under the CLA, which the project requires from every contributor. Thanks for the original PR — the footer removal is what this builds on. |
Summary
Validation
npm run checknpm run typechecknpm run test:run(88 tests)npm run build:app