Skip to content

Remove the authenticated app footer - #377

Closed
sprouty-io wants to merge 3 commits into
Windshiftapp:mainfrom
sprouty-io:remove-authenticated-footer
Closed

sprouty-io wants to merge 3 commits into
Windshiftapp:mainfrom
sprouty-io:remove-authenticated-footer

Conversation

@sprouty-io

@sprouty-io sprouty-io commented Oct 25, 2026 •

Copy link
Copy Markdown

Summary

  • remove the authenticated desktop app footer from the application shell
  • remove its now-unused import and mobile-only layout rule

Validation

  • npm run check
  • npm run typecheck
  • npm run test:run (88 tests)
  • npm run build:app

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (stefan-ernst)[https://github.com/stefan-ernst]
❌ @sprouty-io
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sprouty-io
sprouty-io force-pushed the remove-authenticated-footer branch from 2c1f012 to 2915f65 Compare October 25, 2026 16:02
The pinned footer reserved a strip at the bottom of every authenticated
page. Move it into the page content so it is only reached by scrolling,
and only on document surfaces.

Builds on the footer removal in Windshiftapp#377 by @sprouty-io, which identified
that the pinned footer wasted vertical space. The About, API Reference,
Licenses, and report-problem links stay in the footer.

- add MAIN_APP_FOOTER_VIEWS and place the footer per route wrapper in
  MainRouteContent
- pin the footer to the bottom of short pages with mt-auto
- hide it in review focus mode and on viewport-filling surfaces
- add stable data-testids to the footer and its links
@stefan-ernst stefan-ernst changed the title Remove the authenticated app footer refactor(ui): render the authenticated footer at the end of page content Oct 25, 2026
@stefan-ernst stefan-ernst changed the title refactor(ui): render the authenticated footer at the end of page content Remove the authenticated app footer Oct 25, 2026
@stefan-ernst

Copy link
Copy Markdown
Contributor

Picked this up and extended it into a full relocation, since the branch now moves the footer rather than dropping it.

The pinned footer reserved a strip at the bottom of every authenticated page. This moves it into the page content so it is only reached by scrolling, and only on document surfaces.

Builds on @sprouty-io's footer removal here, which identified that the pinned footer wasted vertical space. The About, API Reference, Licenses, and report-problem links stay in the footer.

  • MAIN_APP_FOOTER_VIEWS opt-in set; MainRouteContent places the footer per route wrapper
  • pinned to the bottom of short pages with mt-auto
  • hidden in review focus mode and on viewport-filling surfaces (boards, canvases, Svelte Flow designers)
  • stable data-testids added for the footer and its links

Validation:

  • bun run typecheck
  • full Vitest suite (3053 tests)
  • bun run check
  • run-e2e.sh tests/app-footer.spec.ts

stefan-ernst added a commit that referenced this pull request Oct 26, 2026
The pinned footer reserved a strip at the bottom of every authenticated
page. Move it into page content so it is only reached by scrolling, and
only on document surfaces; viewport-filling surfaces (boards, canvases,
Svelte Flow designers) keep no footer.

MAIN_APP_FOOTER_VIEWS and isMainAppFooterView() gate the placement per
route. MainRouteContent renders the footer after the route resolves (never
during loading, on error, or in review focus mode), and mt-auto pins it to
the bottom of short pages.

Builds on the footer removal by @sprouty-io in #377.
@stefan-ernst

Copy link
Copy Markdown
Contributor

Superseded by 22c0122 on main, which lands the same relocation of the authenticated footer to the end of opted-in page content.

The change is credited to @sprouty-io, whose commit here first identified that the pinned footer wasted vertical space. It lands as a maintainer-authored commit rather than a merge of this branch because @sprouty-io's commit is unsigned under the CLA, which the project requires from every contributor.

Thanks for the original PR — the footer removal is what this builds on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants