Media: Use unique placeholders during export - #861
Open
MaggieCabrera wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces collision-resistant media placeholders during theme export, preserving placeholder-like template content.
Changes:
- Generate UUID-based placeholders and verify they do not exist in source content.
- Add regression coverage for block metadata, text, and media localization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
includes/create-theme/theme-media.php |
Generates unique, collision-checked export placeholders. |
tests/test-theme-media.php |
Tests preservation of placeholder-like content. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use unique temporary placeholders when localizing media URLs during theme export.
This keeps placeholder-like text and block metadata unchanged while preserving normal media localization.
Test plan
vendor/bin/phpunit -c phpunit.xml.dist --verbose --filter Test_Create_Block_Theme_Mediavendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-media.php tests/test-theme-media.php