i18n: Preserve block attribute encoding - #863
Open
MaggieCabrera wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts localized export handling so block attribute JSON retains WordPress Core’s canonical encoding for non-localized attributes, while still substituting localized attribute values after serialization.
Changes:
- Update
CBT_Theme_Locale::escape_block_attribute_strings()to re-serialize attributes viaserialize_block_attributes()and then replace localized values using unique placeholders. - Add a unit test ensuring sibling (non-localized) attributes keep Core’s encoding (e.g.,
\u003c,\u0022,\u002d\u002d) while localized values are still injected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
includes/create-theme/theme-locale.php |
Reworks attribute re-encoding to preserve Core encoding and only substitute localized values post-serialization. |
tests/CbtThemeLocale/escapeBlockAttributes.php |
Adds regression coverage to confirm non-localized attributes remain Core-encoded after localization processing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve WordPress Core’s encoding for block attributes during localized export.
Only localized values are substituted after serialization, leaving all other attributes encoded consistently with Core.
Test plan
vendor/bin/phpunit -c phpunit.xml.dist --verbose --filter CBT_Theme_Locale_EscapeBlockAttributesvendor/bin/phpunit -c phpunit.xml.dist --verbose --group localevendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-locale.php tests/CbtThemeLocale/escapeBlockAttributes.php