Export: Remove image classes by token - #864
Open
MaggieCabrera wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines template export cleanup for core/image and core/cover blocks by removing the environment-specific wp-image-{id} class using WP_HTML_Tag_Processor, so only the exact class token is removed and similar text in the markup is preserved.
Changes:
- Replace substring-based removal of
wp-image-{id}withWP_HTML_Tag_Processorclass-token removal during export. - Add a regression test ensuring only the matching class token is removed while similar text remains intact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/create-theme/theme-templates.php |
Switches image class cleanup to token-based removal via WP_HTML_Tag_Processor when stripping the image id. |
tests/test-theme-templates.php |
Adds a test case to verify only the exact wp-image-{id} class token is removed and similar text is preserved. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove environment-specific image classes through the HTML processor during export.
This limits the cleanup to the matching class token and preserves similar text elsewhere in block markup.
Test plan
vendor/bin/phpunit -c phpunit.xml.dist --verbose --filter Test_Create_Block_Theme_Templatesvendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-templates.php tests/test-theme-templates.php