Skip to content

Export: Remove image classes by token - #864

Open
MaggieCabrera wants to merge 2 commits into
trunkfrom
codex/export-parse-image-class-cleanup
Open

Export: Remove image classes by token#864
MaggieCabrera wants to merge 2 commits into
trunkfrom
codex/export-parse-image-class-cleanup

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Summary

Remove environment-specific image classes through the HTML processor during export.

This limits the cleanup to the matching class token and preserves similar text elsewhere in block markup.

Test plan

  • vendor/bin/phpunit -c phpunit.xml.dist --verbose --filter Test_Create_Block_Theme_Templates
  • vendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-templates.php tests/test-theme-templates.php
  • Confirmed the image ID and matching class are removed while similar markup remains unchanged.

@MaggieCabrera
MaggieCabrera requested review from scruffian and a lite review from Copilot August 20, 2026 15:15
@MaggieCabrera MaggieCabrera self-assigned this Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines template export cleanup for core/image and core/cover blocks by removing the environment-specific wp-image-{id} class using WP_HTML_Tag_Processor, so only the exact class token is removed and similar text in the markup is preserved.

Changes:

  • Replace substring-based removal of wp-image-{id} with WP_HTML_Tag_Processor class-token removal during export.
  • Add a regression test ensuring only the matching class token is removed while similar text remains intact.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
includes/create-theme/theme-templates.php Switches image class cleanup to token-based removal via WP_HTML_Tag_Processor when stripping the image id.
tests/test-theme-templates.php Adds a test case to verify only the exact wp-image-{id} class token is removed and similar text is preserved.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread includes/create-theme/theme-templates.php
Comment thread tests/test-theme-templates.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants