Preserve original error and stack trace on hb appender - #517
Merged
ektor-vrettakis merged 1 commit intoSep 7, 2026
Merged
Conversation
…sing the actual error instance when present & keep additional info as extra content
ektor-vrettakis
requested review from
echetzakis,
klesgidis,
kzacharakis,
nikosd23 and
stavros-wb
as code owners
September 7, 2026 09:40
stavros-wb
approved these changes
Sep 7, 2026
ektor-vrettakis
deleted the
preserve-original-error-and-stack-trace-on-hb-appender
branch
September 7, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve previously discarded non-enumerable error properties by exposing the actual
Errorinstance when one is present, while retaining any additional information as extra context.Callers commonly log a descriptive string before the real error, e.g.
logger.error('Notifications scheduler failed with error:', err)Previously, the descriptive string was always reported as the error, causing the real Error's message and stack to be discarded. Only its own
enumerableproperties were preserved throughbuildContext.e.g. https://app.honeybadger.io/projects/102562/faults/116056135