Enable remote base shell builds - #171
Closed
quetric wants to merge 1 commit into
Closed
Conversation
…st a remote executor e.g. LSF
Collaborator
|
Overall this is good, but I see a couple of issues. The current flow is This should be preserved, and the new correct flow should be: Otherwise, if the shell is built before the debian and rpm packager start the build process they will consider the built design a source file, which may cause some issues. The second issue is that the check for v++ availability happens in build-base-shell.sh which does not run remotely, and should be presumably moved to root-design-build.sh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify build scripts to enable base shell vivado build to be launched against a remote executor e.g. LSF