Repository navigation
Align gym profiles and plate loading across web and Android - #11
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved gym setup on the web used comma-separated sizes and a separate quantity list. It now uses native-style plate rows, pair counters, colors and unavailable-equipment controls, with activation, duplication and confirmed deletion. Active gym and calculator stock update atomically; native backup edits take precedence over stale extensions.
The Android plate calculator now finds bounded combinations that greedy loading missed (44 kg on a 20 kg bar with 10/6 kg stock), preserves colors and respects an empty saved inventory. Nonfinite editor values are rejected. Android version advances to pre-alpha.9 (code 10).
Validation: 230 web tests, TypeScript and production output checks; 762 Android JVM tests, debug lint with zero errors and signed release assembly; 46 Chromium/WebKit acceptance scenarios. The new editor was also exercised at 320 px. The checkpoint records remaining parity work and preservation of UnifiedPort edits.
The final calculator pass also fixes converted pound stock, including four 5 lb plates per side. Canonical weights stay intact, loading exactness is checked before formatting, and the web unlimited-stock path uses the same bounded search. Both regression tests were observed failing before the correction. The APK is rebuilt and smoke-tested again before release.