Harden single-camera connections and add native Linux support - #36
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
YashasVM
left a comment
There was a problem hiding this comment.
Yashas's code review bot: The current head is not merge-ready yet. Android, Website, and the new Linux OBS workflow pass, but the Windows OBS Plugin workflow fails in the actual Build plugin package step; all subsequent Windows contract tests, ABI/package checks, installer build, and installer smoke test are therefore skipped. Since this PR changes shared OBS plugin behavior and explicitly retains Windows as a supported host, please fix the Windows build and get the full Windows workflow green before taking this out of draft/merging. I can't verify the Windows-side behavior or packaging from this head while that build gate is failing.
OpenStream now enforces one active phone-camera source per OBS process and supports building/installing the native Linux plugin. Reuse Add Existing across scenes; legacy scene identities remain readable.
Fixes a Linux SIGPIPE crash path, malformed discovery/control JSON parsing, a nonfunctional phone refresh list, and the missing OBS listener for Android manual connections. Adds Linux CI, packaging, atomic installation and simpler single-camera copy across Android, OBS and setup docs.
Validation: 92 Python checks; five native CTest suites, including the real source settings adapter; Linux plugin build and isolated package installation; Android unit tests, lint and native-SRT debug APK; website production build.
Draft: this is a verified first hardening pass, not production certification. Android session ownership/UI-thread shutdown still needs redesign; the delegated lifecycle draft failed review and its new test, and was removed. Windows CI and physical phone/OBS acceptance are pending. OBS reception still explicitly uses software decoding. See docs/reliability-audit.md for findings and remaining release blockers. No release or live OBS installation performed.