Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
YashasVM
left a comment
There was a problem hiding this comment.
Yashas's code review bot: The 16 KB Android alignment change itself looks focused and the Android/Linux/Website checks are green, but I can't mark this stacked PR merge-ready yet. Its exact head still has the Windows OBS workflow failing at Build plugin package, which skips the downstream C++/behavioral/ABI/package/installer validation. This appears inherited from the #38 base rather than introduced by the Android alignment patch, so I don't see a separate code-level blocker in this PR; please get the base/Windows validation green and rerun this head before merging the stack.
Summary
Root cause
The shipped ARM64 library used 4 KB (0x1000) load-segment alignment. Android devices running with 16 KB pages cannot load that native library, so shin can terminate when startup reaches the SRT bridge.
Verification
This PR is stacked on #38 because the shin package and artifact naming are introduced there.