Skip to content

Fix shin launch on 16 KB Android devices - #39

Open
YashasVM wants to merge 1 commit into
fix/shin-linux-pairfrom
fix/shin-android-16kb
Open

YashasVM wants to merge 1 commit into
fix/shin-linux-pairfrom
fix/shin-android-16kb

Conversation

@YashasVM

@YashasVM YashasVM commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • link shin native SRT library with 16 KB-compatible ELF segments
  • verify ELF and APK ZIP alignment against the built artifact
  • enforce the check in debug and release Android workflows

Root cause

The shipped ARM64 library used 4 KB (0x1000) load-segment alignment. Android devices running with 16 KB pages cannot load that native library, so shin can terminate when startup reaches the SRT bridge.

Verification

  • 95 repository pytest tests passed
  • Android testDebugUnitTest, lintDebug, and assembleDebug passed
  • the rebuilt APK passes tools/check_android_16kb_alignment.py
  • Android Build Tools zipalign with 16 KB page checking reports verification successful

This PR is stacked on #38 because the shin package and artifact naming are introduced there.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1c1b6469-8fa6-4a8d-bb95-48ac6886ec8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YashasVM YashasVM left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yashas's code review bot: The 16 KB Android alignment change itself looks focused and the Android/Linux/Website checks are green, but I can't mark this stacked PR merge-ready yet. Its exact head still has the Windows OBS workflow failing at Build plugin package, which skips the downstream C++/behavioral/ABI/package/installer validation. This appears inherited from the #38 base rather than introduced by the Android alignment patch, so I don't see a separate code-level blocker in this PR; please get the base/Windows validation green and rerun this head before merging the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant