Conversation
Updated `.zektopic/status.md` and `Jules/improvements.md` with the latest backend, frontend, and Rust test execution results. Documented BuildKit issues with native docker tests and highlighted necessary mock improvements for the local `test_runner.py`. Cleaned up temporary files. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
…ation warnings Updates `setup-python@v5` workflow environment variable from `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION` to `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24` to resolve Node 20 deprecation check failures. Fixes typing issues in `frigate/util/object.py` where `average_boxes` and `median_of_boxes` were strictly typing inputs as `list`, causing covariant mismatch errors in `frigate/track/norfair_tracker.py`. Modifies them to accept generic `Sequence`s. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Updates `setup-python@v5` workflow environment variable from `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION` to `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24` to resolve Node 20 deprecation check failures. Fixes typing issues in `frigate/util/object.py` where `average_boxes` and `median_of_boxes` were strictly typing inputs as `list`, causing covariant mismatch errors in `frigate/track/norfair_tracker.py`. Modifies them to accept generic `Sequence`s. Removes `test_runner.py` from the repository root. This ad-hoc local testing script inadvertently shadowed the native `unittest` discovery process in the GitHub Actions container environment. Its top-level `sys.modules` monkeypatching replaced critical dependencies (like Peewee, psutil, and Pydantic) with broken `MagicMocks`, causing the entire native Python test suite to fail with obscure attribute, schema, and operational errors. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
1 participant
Updates the internal tracking documentation with the latest test results across all test suites, as requested by the user, and details the areas in
test_runner.pythat need better dependency mocking (e.g., Pydantic v2 schemas and OpenCV arrays).PR created automatically by Jules for task 6657838872366440782 started by @manupawickramasinghe