Repository navigation
feat(copy): Spanish GitHub alerts and final verification (spanish-copy 3/3) - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of 3 of change
spanish-copy. It translates the GitHub alerts into Spanish and completes the final verification. After this PR, all user-facing bot text is in Spanish.src/domain/copy.tsGITHUB_ALERT_HEADERSis an exhaustiveRecordover all 8kind:actioncombinations: "PR abierto", "Issue cerrado", "Revisión solicitada", and so on. A new event kind or action fails the typecheck.githubCopyholds the labels "Revisor:" and "Por:".src/domain/github.ts: now uses the catalog. Routing, fields and the 256 and 4096 caps are unchanged. Repo names, titles, usernames and URLs from GitHub are interpolated verbatim.test/domain/github.test.tsasserts the exact Spanish header for every combination.Final verification (Phase 4)
I grepped every user-facing reply path in
src/(ctx.reply,answerCallbackQuery,chatPublisher.post, the alert sender and the format functions). No user-visible English remains.Domain exception messages and log event names are still in English, but they never reach chat users:
runCommandreplies only through the SpanisherrorRepliescatalogs.Review
A bounded review at medium risk ran the reliability lens over all 6 changed paths and found nothing.
Tests
🤖 Generated with Claude Code