Skip to content

feat(copy): Spanish GitHub alerts and final verification (spanish-copy 3/3) - #41

Merged
TOMOKI977 merged 3 commits into
mainfrom
feat/spanish-copy-github
Sep 29, 2026
Merged

TOMOKI977 merged 3 commits into
mainfrom
feat/spanish-copy-github

Conversation

@TOMOKI977

Copy link
Copy Markdown
Contributor

Summary

PR 3 of 3 of change spanish-copy. It translates the GitHub alerts into Spanish and completes the final verification. After this PR, all user-facing bot text is in Spanish.

  • src/domain/copy.ts
    • GITHUB_ALERT_HEADERS is an exhaustive Record over all 8 kind:action combinations: "PR abierto", "Issue cerrado", "Revisión solicitada", and so on. A new event kind or action fails the typecheck.
    • The two combinations the mapper never produces get safe placeholder phrases.
    • githubCopy holds the labels "Revisor:" and "Por:".
  • src/domain/github.ts: now uses the catalog. Routing, fields and the 256 and 4096 caps are unchanged. Repo names, titles, usernames and URLs from GitHub are interpolated verbatim.
  • Tests
    • test/domain/github.test.ts asserts the exact Spanish header for every combination.
    • The English-word guard now covers the GitHub copy.

Final verification (Phase 4)

I grepped every user-facing reply path in src/ (ctx.reply, answerCallbackQuery, chatPublisher.post, the alert sender and the format functions). No user-visible English remains.

Domain exception messages and log event names are still in English, but they never reach chat users:

  • runCommand replies only through the Spanish errorReplies catalogs.
  • Unrecognized errors are rethrown without sending text.

Review

A bounded review at medium risk ran the reliability lens over all 6 changed paths and found nothing.

Tests

  • Strict TDD: 13 tests failed (RED) before the implementation.
  • The full suite passes (870 tests), and typecheck is clean.

🤖 Generated with Claude Code

@TOMOKI977
TOMOKI977 merged commit c15192b into main Sep 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant