Repository navigation
feat(participation): Participamos button and hp: callback handler (hackathon-participation 2/3) - #45
Merged
Merged
Conversation
…ton and store its message id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 2 of 3 for change 4,
hackathon-participation, and the last implementation PR. It adds the "✅ Participamos" button. The team confirms participation with one tap from the General analysis, and the bot creates the🏆 <name>topic, posts and pins the analysis there, confirms in General and removes the button.create()error keeps the claim and rethrows.src/domain/usecases/run-hackathon-job.ts: both General post sites go throughpostToGeneral.hp:<slug>) and store the message id. Storing is best-effort: a failure is logged and the job still acks.src/adapters/telegram/context.ts:callbackCallerLocationreads the tapped message's chat and thread.src/adapters/telegram/participation.ts:registerParticipationCallbackhandleshp:callbacks.runParticipationruns. Telegram allows only oneanswerCallbackQuery, so refusals before topic creation are sent as a best-effort chat reply.sel:team picker is unaffected.Review
A bounded review at medium risk ran the reliability lens, including the security checks, on all 10 changed paths. It found no severe findings. It confirmed:
sel:picker.One deferred warning, R3-001:
resolveGroupMembershipruns outside thesafe()wrapper. If the D1 lookup throws, the callback is left unanswered and the webhook returns 500. This is a one-line follow-up.Tests
Operator steps (Phase 4)
/hackathon join <slug>on an old analysis;t.me/c/…link.🤖 Generated with Claude Code