docs(FIX-P5-011): CHANGELOG EC-24 note, CLAUDE.md tree accuracy, field.rs sanitization-scope rustdoc (F5 pass-10) - #905
Merged
Conversation
…d.rs builder sanitization scope (P10 N1/N2, CR10-001/002)
Owner
Author
Claim audit: PR #905 (head
|
| # | Severity | File:line | Finding | Suggestion |
|---|---|---|---|---|
| 1 | NIT | CHANGELOG.md:312-319 | U+2065 is listed under the EC-24 residual, but the EC-24 KEEP-pin test (src/output.rs:1845) does not include it. Its keep behavior is pinned only by the neighbors test (src/output.rs test_bc_7_1_006_sanitize_cf_range_neighbors_kept). The claim is true, but the EC-24 tag is not traceable to the EC-24 test. |
Optionally add 0x2065 to the EC-24 test's array so the test matches the documented set. |
| 2 | NIT | CHANGELOG.md:313 | "human decision D-400/D-401": the code cites only D-400 (src/output.rs:1840). D-401 is not referenced anywhere in src/, so it can't be checked from the diff. |
Confirm that D-401 exists and is relevant, or cite D-400 alone. |
| 3 | NIT | CHANGELOG.md:299 | The header calls the extras "a named set of blank-rendering fillers". That set also contains the combining grapheme joiner (U+034F) and the non-Cf, unassigned tag-block code points. Both are invisible rather than "fillers" in the strict sense. | Optionally reword to "a named set of invisible/blank-rendering extras". |
Not verified (information wall): the field.rs rustdoc's statement that these echoes are "documented residuals (BC-7.1.006 Canonical Sink Inventory)" points to a spec file that is not in this repo diff. The behavioral part of the claim (which values are or are not sanitized) is verified above.
Doc-only change; no code paths are touched. Demo evidence does not apply.
…sible extras (PR #905 NIT 3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only F5 pass-10 fixes (cycle-014, D-405). Files: CHANGELOG.md, CLAUDE.md, src/cli/field.rs (rustdoc only).
P10-001's main fix is spec-side (BC-X.14.001 Invariant 3 documents the deliberate field-resolver divergence, D-405). Feature request: #904.
Risk
No code behavior change. Blast radius: documentation only.
Demo evidence
N/A (doc-only).
Security review
Skipped: doc-only change.