feat: prep npm release — activate publish workflow, add registry metadata#2
Open
a-tokyo wants to merge 1 commit into
Open
feat: prep npm release — activate publish workflow, add registry metadata#2a-tokyo wants to merge 1 commit into
a-tokyo wants to merge 1 commit into
Conversation
…data — 0.1.4 Un-dormants release.yml now that the zoldytech npm org exists: enables OIDC-based `npm publish --provenance`, and creates the GitHub Release only after publish succeeds (so a failed publish can never leave a tag/release with no matching npm version). Adds package.json registry metadata (publishConfig, repository, homepage, bugs) and drops `private: true`. Updates README to the real npm install command and adds npm/CI badges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml: enables OIDC-basednpm publish --provenance(noNPM_TOKENsecret), and creates the GitHub Release after publish succeeds so a failed publish can never leave a tag/release with no matching npm version.package.jsonmetadata: dropsprivate: true, addspublishConfig.access: public,repository,homepage,bugs. Bumps version0.1.3->0.1.4.npm i -D @zoldytech/javascriptinstall command (replacing the GitHub-URL-pinned-tag install), adds npm version/downloads + CI badges.Context
Prompted by creating the
zoldytechnpm org and auditing this repo's CI/release setup againsta-tokyo/apple-signin-auth. That repo creates its GitHub Release beforenpm publish, and itsNPM_TOKENhas been silently expired for over a month — its latest release has no matching npm version with no alerting. This PR sequences the opposite way (publish first, release second) so that failure mode can't happen here.Prerequisite (not part of this PR)
Before the first tag push will actually publish, OIDC trusted publishing needs to be enabled on npmjs.com for this package: Settings -> Trusted Publisher -> GitHub Actions ->
Zoldytech/javascript->release.yml.Test plan
npm run lintpassesnpm testpasses (22/22)release.ymlYAML validatedv0.1.4and confirm the release workflow publishes to npm and creates a GitHub Release0.1.1,0.1.2,0.1.3(tracked separately, not in this PR)