docs: add multi-version documentation support#985
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces documentation versioning support for the A2A Java SDK documentation site, restructuring the content into versioned directories (such as 1.0.0.Final, 1.1.0.Final, and dev) and implementing a client-side version switcher dropdown in the sidebar. The review feedback focuses on improving the robustness of this implementation, including: comparing resolved URL pathnames instead of raw href attributes to prevent search filtering failures with absolute URLs; updating the version switcher to correctly handle sub-pages; wrapping relative links in site.url() to ensure correct resolution; and using the existing CSS variable var(--color-accent-800) instead of a hardcoded color value in the stylesheet.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
4b1bb04 to
d95380b
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a versioned documentation system for the A2A Java SDK website, restructuring content into version-specific directories and implementing a client-side version switcher. Feedback on these changes focuses on improving robustness and URL handling, specifically by adding null and blank validations in the Versions and MenuItem constructors, and ensuring basePath ends with a trailing slash in the JavaScript switcher to prevent broken links.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Add versioned docs with a version dropdown, per-version sidebar menus, and a version-scoped search filter. Content is organized into versioned folders (1.0.0.Final, 1.1.0.Final, dev) with the default version resolved from data files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add versioned docs with a version dropdown, per-version sidebar menus, and a version-scoped search filter. Content is organized into versioned folders (1.0.0.Final, 1.1.0.Final, dev) with the default version resolved from data files.