Repository navigation
Sync from RecastEngine-Pro: lint and types for the carried forward-workload library - #21
Merged
Merged
Conversation
…tion carries The public edition's CI went red on the first sync that carried 113: ruff found eleven findings in the files the export makes public (an unsorted import block in phases.py and in the workspace-resources test, two unsorted __all__, six lines over 100 columns, one single-element slice) and mypy twelve, all one cause -- _require_anchor discriminated the receipt union with `type(receipt) is RecordedSourceBoundaryReceipt`, which mypy does not narrow on the fall-through, so every attribute of the transformation receipt below it was read off the union. isinstance narrows it; both receipts are frozen dataclasses with no subclasses, so the check means the same thing. The three files ruff format would rewrite are formatted. Under the locked ruff (0.16.3) the whole tree still carries 86 findings and mypy 72 errors, all in the withheld JAX rules and reconstruction modules of 111/#112; those are for their author and do not reach the public CI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQ16296JcBrKdbo1q1nKXa Signed-off-by: lewisychen <yueqichen.0x0@gmail.com> Carried-From: f5ebe1400fb7f59f793b8cf94dca19696426ecae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carried by tools/export sync; each commit names its origin in a Carried-From trailer.