feat!: Migrate to tanstack start - Stage 1 - #751
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7394ff3d1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "./framework/request": { | ||
| "import": "./dist/src/framework/request/index.js", | ||
| "types": "./dist/src/framework/request/index.d.ts", | ||
| "default": "./dist/src/framework/request/index.js" |
There was a problem hiding this comment.
Expose adapter setters without importing Next
When a TanStack or other non-Next host imports this public entry point to call setRequestAdapter, index.js eagerly imports the Next adapter, which loads server-only and next/* before the custom adapter can be installed; the adjacent cache entry point has the same problem. The framework-independent runtime.js files cannot be imported instead because they are not listed in exports, so Node rejects those subpaths. Export a framework-neutral registration entry point, or avoid eagerly installing the Next defaults from the only public modules.
Useful? React with 👍 / 👎.
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?