Repository navigation
Evaluate as a landing page at its own address, the counted figures, and the line under the hero - #383
Merged
Merged
Conversation
…e developer to Evaluate Four things a reader deciding on abap2UI5 did not get from the site: - The size of the thing. The framework README counts its tests, specs, browser suites and gates (`npm run facts`), and the site printed none of it. scripts/lib/facts.mjs reads that block at build time (from the clone A2UI5_HOME names, else raw GitHub) plus the star count from the GitHub API, and build-site prints one quiet line under the hero and wherever a page carries <p class="a2ui5-facts"></p>. No number is typed in this repository; a read that fails costs the line, never the build, and the build log says which half was not read. - What the primary button costs. A line under the hero's buttons says it: nothing to install, no trial license, no sales call. - A picture on Evaluate. The reader of that page does not open the playground; the tutorial app's screenshot stands under the intro, with the figures under it. - The way from the developer to the person who approves. Hello World's "what next" list and the Quickstart's next steps each name Evaluate as the page to send rather than the argument to make. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPRYeJhVLkXoHZepaxgpzG
The page for the person who approves abap2UI5 was a chapter: sidebar, outline, and "Documentation > Getting Started" over its first line. A developer sends that link to the person who decides, and that person landed in the manual. It is `layout: landing` now, the second non-chapter layout of build-site.mjs: the hero carries the name, the claim, the intro, the two doors and the line under them; the tutorial app's screenshot stands where the front door has its mark, at the width a screenshot needs; the counted figures stand under the hero; the H2 sections are bands across the width with real tables; the four ways to start are tiles at the end, so the last section does not list them a second time; the bar marks no section. The H1 stays in the body for the search index and the sidebar test, and the layout prints it in the hero once. The address is /evaluate rather than /get_started/evaluate, so the link itself does not say "manual". The old address lived one day and is linked from the framework's README and two of its docs pages, so a stub keeps it answering, fragment included. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPRYeJhVLkXoHZepaxgpzG
oblomov-dev
changed the title
4 of 6 tasks
The bar gets a fifth section, AI Studio, after Playground - the change lands in abap2UI5/playground first, and the published pages borrow the bar from there at build time, so this side only brings the theme's copy (SiteNav.vue, the second opinion) and the builder's comment into step. Nothing else here reads the item. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPRYeJhVLkXoHZepaxgpzG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two readers, one site. The developer's side is in order: bar, search, playground, samples. The person who approves abap2UI5 got a chapter: sidebar, outline, "Documentation › Getting Started" over the first line, and no number or picture anywhere. Compared with the other ways to put a UI on SAP, the site's strongest claims were implicit: free to try with nothing installed, and held by a large test and gate set.
What
Evaluate is a landing page now (
layout: landing, the second non-chapter layout ofbuild-site.mjs), at/evaluaterather than/get_started/evaluate, so the link a developer sends does not say "manual":docs/public/get_started/evaluate.htmlkeeps it answering, fragment included (AGENTS.md: thirty-two stubs now)The counted figures, read, not typed.
scripts/lib/facts.mjsreads the framework README'sfacts:startblock at build time (from the cloneA2UI5_HOMEnames viagit show, else raw GitHub) and the star count from the GitHub API.build-site.mjsprints one quiet line under the hero of the front door and the landing page, and wherever a page carries<p class="a2ui5-facts"></p>. This repository types no number of its own; a read that fails costs the line, never the build, and the build log says which half was not read. Documented inAGENTS.md.A line under the front door's hero buttons: nothing to install, no trial license, no sales call.
Developer → approver. Hello World's "what next" list and the Quickstart's next steps each name Evaluate as the page to send.
Checks
npm run checkgreen locally exceptcheck:api-reference(fails onmaintoo; separategenerate:apicommit). The dead-link sweep walks the new stub. The star read returned 403 from inside this sandbox's proxy and the line printed without it, which is the designed behavior; CI has plain network access.Follow-up
abap2UI5/abap2UI5 gets a one-line follow-up that points the README and the two docs stubs at
/docs/evaluate.html; until then the stub here redirects them.🤖 Generated with Claude Code
https://claude.ai/code/session_01KPRYeJhVLkXoHZepaxgpzG