Repository navigation
Canvas: a render that fails or stalls says so and never blocks the next - #4
Merged
Merged
Conversation
In the preview frame, anything that threw after the old view was destroyed - a model that does not apply, a renderer that fails on a value - left the canvas blank and `rendering` true for ever: every later edit was queued behind it and never shown, with no word why. Now every render ends, in a view or in an error on the canvas and in the designer's status line; a view creation UI5 does not answer within 20 seconds is reported too; a model-only update counts as a render, so the status clears. UI5's own error log (an invalid property value, a binding it cannot parse) reaches the status line as a warning. The status line offers to reload the canvas. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wdz84WSKQE9qRrS2Gu9dWp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The canvas sometimes went blank with no word why, and stayed blank for every later edit until the page was reloaded.
In the preview frame, anything that threw after the old view was destroyed - a model that does not apply, a renderer that fails on a value - left the canvas empty and the frame's
renderingflag true for ever: every later render was queued behind it and never shown. A control module the CDN never delivers held the canvas the same way.What
Follow-up to #3; the one commit after its merge, rebased onto main.
Verification
npm test(186),npm run check:abap(0 findings),npm run test:e2eon UI5 1.144.0 and 1.71.80 (36).🤖 Generated with Claude Code
https://claude.ai/code/session_01Wdz84WSKQE9qRrS2Gu9dWp
Generated by Claude Code