Repository navigation
Re-vendor the Adaptive Cards renderer; keep a newer session with the same draft id on eviction - #49
Merged
Merged
Conversation
The renderer now shares renderers/common/{view,request}.mjs with the
protocol's other renderers, and the view half reads the portable profile:
the vendor script copies them too (lib/vendor/adaptive-cards/common/,
profiles/) and rewrites every relative path to the vendored copy or, for
the agent modules, to lib/ - a path to anything else fails the vendoring.
Brings in: app text with Markdown syntax is a TextRun (no live links from
app data in Teams/Copilot); a linear htmlToText.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013nvd2W2zUT5ZyemG91n2oq
Sessions started from one screen share its draft id - the playground's Pilot starts one from its mirror on every change of the reader's typing - and remember( ) deleted every id of the evicted session from the index, the newest session's included: "unknown session 'D1' - open sessions: D1". Only the ids that still name the evicted session are dropped now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013nvd2W2zUT5ZyemG91n2oq
oblomov-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Re-vendor the Adaptive Cards renderer
This re-vendors the renderer at abap2UI5/protocol@29aad60, which is abap2UI5/protocol#4 merged.
What it brings:
RichTextBlock/TextRun. Before, a model value or a toast like[verify your account](https://evil.example)became a live link in Teams and Copilot.htmlToText(used for message box details) is now linear.The vendor script had to change. Since the last vendoring, the renderer shares its view and request halves with the protocol's other renderers (
renderers/common/), and the view half readsprofiles/portable-v1.json.scripts/vendor-adaptive-cards.mjsnow copies those files as well, tolib/vendor/adaptive-cards/common/andprofiles/.lib/.test/vendor.test.mjsandtest/ascii.test.mjsnow walk the folder recursively, and the import rule resolves each import.AGENTS.mdandCHANGELOG.mdare updated.2. appclient: evicting a session keeps a newer one with the same draft id
Sessions started from one screen share its draft id. The playground's Pilot starts one from its mirror every time the reader's typing changes. When the oldest of these was evicted,
remember( )deleted every one of its ids from the index, including the id the newest session still used. Five starts withmaxSessions: 4gave "unknown session 'D1' - open sessions: D1, D1, D1, D1". Only ids that still point to the evicted session are dropped now, and there is a regression test intest/appclient.test.mjs.Checks
A2UI5_MCP_SKIP_NETWORK_TESTS=1 npm test(with Chromium and a protocol checkout beside the repository): green. The renderer commit alone gave 442 passed, 15 skipped; the eviction fix adds one test.node scripts/vendor-adaptive-cards.mjs ../protocol --check: up to date (7 files).After merge, the playground and protocol re-vendor
appclient/snapshot/viewxmlat this commit.🤖 Generated with Claude Code
https://claude.ai/code/session_013nvd2W2zUT5ZyemG91n2oq