Repository navigation
Copy the 200-rule app rule set into the conformance apps' abaplint config - #7
Merged
Merged
Conversation
…nfig The rule block is abap2UI5's .github/abaplint/app-rules.json copied unchanged (the file's header says so). abap2UI5/abap2UI5#2889 adds the thirteen rules abaplint 2.120.73 ships that the set did not name: cds_check_syntax, else_after_all_returns, prefer_abap_bool, prefer_abap_bool_values, preferred_parameter_ignored, unnecessary_loop_guard, wrong_abapdoc_position, xml_bom and use_message_class on; prefer_string_template, prefer_insert_into_table, no_dynamic_stuff and generic_regex off. The conformance apps have 0 findings under the new block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This was referenced Oct 11, 2026
4 of 6 tasks
oblomov-dev
added a commit
to abap2UI5/abap2UI5
that referenced
this pull request
Oct 11, 2026
…2893) * check:shared: hold abap2UI5/protocol's copy of the app rule set too abap2UI5/protocol#7 copied .github/abaplint/app-rules.json into conformance/apps/abaplint.jsonc, the config the ABAP conformance apps are linted with ("copied unchanged - except object_naming"). Nothing compared that fourth copy. It is now an entry of its own in SHARED - the copy sits in another file there - compared like the three app repositories' copies, as parsed settings minus object_naming; the two readers are shared by both entries. Read from the sibling checkout or raw GitHub, like the others. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt * app-rules.json: the note names abap2UI5/protocol's copy as the fourth The note told whoever changes the rule set to copy it into the three app repositories. abap2UI5/protocol's conformance apps carry a fourth copy, held to it by check:shared since the previous commit - a change copied into three of them now fails that gate in the pull request that makes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule block in
conformance/apps/abaplint.jsoncis abap2UI5's shared app rule set (.github/abaplint/app-rules.json), copied unchanged except forobject_naming. The file's header says so. abap2UI5/abap2UI5#2889 adds the 13 rules abaplint 2.120.73 ships that the set did not name yet. This PR copies them in, at the same alphabetical positions and with the same settings:cds_check_syntax,else_after_all_returns,prefer_abap_bool,prefer_abap_bool_values,preferred_parameter_ignored,unnecessary_loop_guard,wrong_abapdoc_position,xml_bomuse_message_class. The exclude is a samples-stack class and matches nothing here, but the block is copied unchanged.prefer_string_template,prefer_insert_into_table,no_dynamic_stuff,generic_regex. The reasons are in the sample repositories'abaplint.jsoncand in abap2UI5#2889.The block now has the same parsed settings as the new
app-rules.json(200 rules plusobject_naming). No gate compares this copy automatically: abap2UI5'sshared-file-gate.mjsdoes not list protocol as a consumer. The copy stays in sync only by convention.Merge order: these five PRs belong together
Merge the four abap2UI5/sample PRs together, one right after the other: their
check-app-rules/check:sharedgates read each other'smainand are red in between. This PR has no gate tied to the others and is green on its own. Merge it with them so the copy matches the source again.Verified locally
npm run lint:abap: 0 issues, 18 filesnpm test: 84/84🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code