Repository navigation
view-gates: only a push to main gets a token that can write - #269
Merged
Merged
Conversation
The view_gates job held contents: write on every run, pull requests included, for the one step that publishes the badges - a step that already skipped itself on a pull request. The publish is its own job now (`badges`, needs view_gates, runs on a push to main only, the one job with contents: write); view_gates hands it the badge files as an artifact and runs with the workflow default, contents: read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the maintainer's decision on workflow permissions (round 5; the decision named samples and samples-stack,
view-gates.yamlis this repository's badge workflow with the same shape).The
view_gatesjob raisedcontents: writeon every run, pull requests included, for the one step that publishes the badges - a step that already skipped itself on pull requests.view_gatesruns with the workflow default,contents: read.badges, 1 day, only on a push tomainafter a green gate).badges:needs: view_gates,if: github.event_name == 'push' && github.ref == 'refs/heads/main',permissions: contents: write; checks out, downloads the artifact and runs the unchanged publish script. No artifact -> the download may fail and the script's "nothing to publish" warning applies.Actions are the SHA pins this repository already uses. On this PR the
badgesjob shows as skipped; the first push tomainafter the merge exercises it. Other workflows withcontents: writehere (auto-downport, bump-a2ui5, bump-linter, generate-result, sync-shared) do not run on pull requests and are unchanged.Independent of the abaplint 2.120.75 PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code