Repository navigation
bump-a2ui5: commit the prose --fix rewrites, and gate that it does - #273
Merged
Merged
Conversation
The resolve step runs `check-pins.mjs --fix`, which rewrites the pin citation in the prose files. create-pull-request then commits only the paths in `add-paths` - A2UI5_PIN and the abaplint configs, none of the prose - so the rewrite was thrown away. The bump to f9dc871a (#270) moved the pin, left AGENTS.md citing 2dd43637, and turned check_pins red on main the moment it merged (#272 fixed the cell by hand). - bump-a2ui5.yaml: add-paths lists the nine PROSE files of check-pins.mjs, with a comment saying why they are there. - check-pins.mjs policy 7: every PROSE file that exists must be in the bump's add-paths. On the old workflow it reports all nine; on this one it passes. The two lists are one list now, held together by the gate, so a file added to PROSE later cannot be silently dropped again. - tooling.test.mjs: a case for policy 7 - the #270 shape fails, the listed file passes. npm test: 64/64. node scripts/check-pins.mjs: ok. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the bump left AGENTS.md behind
bump-a2ui5.yamldoes runnode scripts/check-pins.mjs --fixafter moving the pin, and the script does rewrite the pin citation inAGENTS.md. The next step,peter-evans/create-pull-request, then commits only the paths inadd-paths:A2UI5_PIN,abaplint.jsoncand.github/abaplint, none of the prose files. So the correctedAGENTS.mdwas thrown away. The bump tof9dc871a(#270) moved the pin but leftAGENTS.mdciting2dd43637, andcheck_pinsturned red onmainas soon as it merged. #272 fixed the cell by hand.The fix
bump-a2ui5.yaml:add-pathsnow lists the ninePROSEfiles thatcheck-pins.mjs --fixcan rewrite. A comment explains why they are there.check-pins.mjs, new policy 7: everyPROSEfile that exists must appear in the bump workflow'sadd-paths. On the old workflow it reports all nine missing files; on this one it passes. The two lists are now kept in sync by the gate, so a file added toPROSElater cannot be dropped silently again.tooling.test.mjs: a test for policy 7. The chore: bump the pinned abap2UI5 framework commit #270 shape fails, and listing the file makes it pass.Checks
npm test: 64/64node scripts/check-pins.mjs: ok (bump add-paths cover the 9 prose file(s) --fix can write)add-pathsreads back as the 12 expected paths.🤖 Generated with Claude Code
https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW
Generated by Claude Code