Repository navigation
Freestyle: report a failed start of #left and #right as well - #15
Merged
Merged
Conversation
#left and #right of the freestyle example had no componentFailed handler: when either could not start (a logon page instead of the bundle, a backend that is down) the frame stayed empty without a word, while #single said why. Both now show the same toast. The logon-page test takes the first of the three toasts, which all three controls now raise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
#leftand#right(two instances, two sessions) now handlecomponentFailedwith the controller's existingonComponentFailed. That handler shows the same "abap2UI5 could not start: ..." toast that#singleshows..first()of those toasts, because all three controls fail together there. The other failure tests already did this.Why
Before, a failed start of either side-by-side container (a logon page instead of the bundle, a backend that is down) left an empty frame with no message, while
#singlesaid why. The round-4 review flagged this.It also helps with the intermittent
samplesfailure in embed-control's CI: the beforeEach waits for 3 Post buttons and sometimes gets only 1. With this change, the page snapshot of such a run will show why the other two did not start.Checked
npm run lintandnpm run format:checkpass.npx playwright test --project ui5-1.136 --project ui5-1.71: 45 passed, 1 skipped. This ran locally against abap2UI5 main on port 3000, with@abap2ui5/embed-control0.2.0 from embed-control'smainunpacked intonode_modules(not committed).main: the tests that need 0.2.0 fail until 0.2.0 is published and the lockfile is bumped. That is not caused by this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code