Repository navigation
README and test comments: the embedded root is a sap.m.NavContainer after abap2UI5 1.147.0 - #17
Merged
Merged
Conversation
…fter abap2UI5 1.147.0 abap2UI5/abap2UI5#2913 gives an embedded component a sap.m.NavContainer as its root; the release after 1.147.0 also leaves the busy indicator and the title to the host. The known limitations and two e2e comments said sap.m.App is the root on every release. The tests themselves hold on both: the control's root-content marker still stops sap.m.Shell's walk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GPMAtn6BycCF2mKRUHGpek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
sap.m.Approot) are now limited to abap2UI5 up to 1.147.0. The release after it leaves them to the host, with asap.m.NavContaineras the root.test/e2e/card.spec.mjs,test/e2e/freestyle.spec.mjs: the comments on the height tests namesap.m.Appas the root up to 1.147.0. The assertions don't change.Why
abap2UI5/abap2UI5#2913 gives an embedded component a
sap.m.NavContaineras its root instead of the full-screensap.m.App;ownsPagekeeps thesap.m.App. The release after 1.147.0 also leaves the busy indicator, the title, the favicon and the "leave page?" prompt to the host (abap2UI5, 2026-10-12).The tests hold on both releases:
sap.m.Shellof the example apps still walks up the DOM;data-sap-ui-root-contentmarker stops that walk as before.The matching docs change in the control is abap2UI5/embed-control#30. Both should be merged after abap2UI5/abap2UI5#2913.
Checked
npm run lint: clean.npm run format:check: all files in Prettier style.npm run buildor the e2e tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01GPMAtn6BycCF2mKRUHGpek
Generated by Claude Code