Repository navigation
Two abap2UI5 apps side by side in the Fiori elements examples - #18
Merged
Merged
Conversation
The object pages of both Fiori elements examples now run two abap2UI5 apps, each in a section of its own and in a session of its own - the case a host app meets as soon as it has more than one thing the annotations cannot say. - fiori-elements (OData V4): a second custom section after the first, Abap2UI5SecondSection.fragment.xml, started with the same customer key. - fiori-elements-v2 (OData V2): a second object page extension after a new facet "Language" (metadata extension and mock annotations in step - a facet takes one extension after it), Abap2UI5Languages.fragment.xml, started with the country alone. - abap/: Z2UI5_CL_EMBED_LANGUAGES, the second app on a system - the country's name in every language of the system, from T005T and T002. - build-bsp.mjs: the patch of the branch rap is a list of replacements; it starts Z2UI5_CL_EMBED_COUNTRY and Z2UI5_CL_EMBED_LANGUAGES there. Locally both sections of both examples run the hello world app, as before. - e2e: a test per example that the two apps keep their states apart; the existing tests take the first container and expect one start per section. - READMEs and AGENTS.md describe two sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8YZcvCPtVUaDxowHh6x1k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The object pages of both Fiori elements examples now run two abap2UI5 apps, each in a section of its own and in a session of its own.
fiori-elements(OData V4): a second custom section, placed after the first one (Abap2UI5SecondSection.fragment.xml). It is started with the same customer key.fiori-elements-v2(OData V2): a second object page extension after a new facetLanguage(Abap2UI5Languages.fragment.xml). It is started with the country alone.Language).Z2UI5_UI_EMBED_COUNTRY_O2_VAN.xml) change in the same commit, as AGENTS.md asks.abap/: a new classZ2UI5_CL_EMBED_LANGUAGES, the second app on a system. It lists the country's name in every language of the system, read fromT005Tjoined withT002. The.clas.xmlfollows the existing CLAS sidecar.build-bsp.mjs: thepatchof the branchrapis now a list of replacements, sorapstartsZ2UI5_CL_EMBED_COUNTRYandZ2UI5_CL_EMBED_LANGUAGES.SHOWNalso checksAfterFacet|Countries|Language. Locally both sections of both examples still run the hello world app.Why
An object page with more than one thing the annotations cannot express needs more than one embedded app. The examples now show that and test it: two controls on one page means two independent sessions and one frontend bundle per page. The branch
rapgives a complete demo on a system, for example as a GIF for a blog post. Each section shows a different app built from real system data.Checked
npm run lint,npm run format:check: clean.npm run abaplint: 0 issues.npx @abap2ui5/linter fiori-elements-v2/abap: 0 failing.npm run build: succeeds.ABAP2UI5_DIR=../abap2UI5 npm run bsp:out/rap/src/01has the new class, andsrc/02starts both classes.npx playwright test --project fiori-elements --project fiori-elements-v2against@abap2ui5/node-runtime1.146.0 on port 3000: 10 passed, 2 of them new.🤖 Generated with Claude Code
https://claude.ai/code/session_01B8YZcvCPtVUaDxowHh6x1k
Generated by Claude Code