Repository navigation
Carry the corrected view-chain-layout skill, and drop spoofed connection markers in the WebSocket sample - #104
Merged
Conversation
…only by construction, not by a check The abap2UI5 repository is the source of this skill; its paragraph on what the linter checks claimed a verification that @abap2ui5/linter 0.9.0 does not perform. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
…nection markers __NEW_CONNECTION__ and __CLOSED__ are what on_start and on_close broadcast; a client that typed one counted as a joined or left connection on every other screen. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of 2026-10-22.
.claude/skills/view-chain-layout/SKILL.mdbyte-identical to the core's corrected copy. Merge together with abap2UI5/abap2UI5, samples and samples-controls on the same branch name; the core'scheck:sharedis red until all four carry it.z2ui5_cl_smps_app_489_ws: a client text matching__*__is dropped before broadcasting, so a client cannot spoof__NEW_CONNECTION__/__CLOSED__.Not done: porting
src/10onto the core'sz2ui5_if_ui5_llm— the package's ISLM provider (ABAP AI SDK, no HTTP), its SM59/cloud transports and its config-table contract have no counterpart in the core seam.npm run checkgreen.Generated by Claude Code