Skip to content

abaplint: exclude samples-controls apps 649/668/671 from 7bit_ascii - #884

Merged
oblomov-dev merged 1 commit into
mainfrom
claude/festive-brown-66e47b
Oct 21, 2026
Merged

oblomov-dev merged 1 commit into
mainfrom
claude/festive-brown-66e47b

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

This copies the shared rule-set change from abap2UI5/abap2UI5#2928 into this repository's abaplint.jsonc. The 7bit_ascii exclude list gains the samples-controls apps 649, 668 and 671.

Those are new ports of sap.m.sample.p13n.EngineMultipleController and sap.f.sample.HeroBanner* from abap2UI5/samples-controls#276. They keep the original's Peter Müller and €4.2M verbatim.

This is a config-only change; no sample in this repository is affected. npm run check:app-rules matches the shared set when it is run against the abap2UI5 branch.


Generated by Claude Code

Copy of the shared rule set change in abap2UI5/abap2UI5#2928: the new
samples-controls ports keep the original's 'Peter Müller' and euro sign.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PTMAfPJZ78qd9zmLoHGZwx

Copy link
Copy Markdown
Member Author

check-app-rules fails here because the shared rule set has not changed yet. The check compares this abaplint.jsonc against abap2UI5 main, and main does not yet carry the three new 7bit_ascii excludes. They are added in abap2UI5/abap2UI5#2928.

There is no code fix for this PR. Merge order: abap2UI5/abap2UI5#2928 first, then this PR, abap2UI5/protocol#10 and abap2UI5/samples-controls#276. Once #2928 is on main, re-running this check turns it green.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants