Repository navigation
Carry the corrected view-chain-layout skill, move the linter to 0.9.0, and build sample 061 on SYST instead of the draft table - #885
Merged
Conversation
…only by construction, not by a check The abap2UI5 repository is the source of this skill; its paragraph on what the linter checks claimed a verification that @abap2ui5/linter 0.9.0 does not perform. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
0.9.0 adds omit-initial-drops-false, and sample 507's second list is the pitfall that rule names, on purpose - suppressed on that one line with the reason; the third list is the fix the rule asks for. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
…draft table Z2UI5_T_01 is the framework's internal draft store, not an API (building apps, section 5), and the sample was the one non-released-api suppression in the corpus. SYST exists on every release, ABAP Cloud included, and sy fills the rows by name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qid1F6VFxWyQLPvqsr1woq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of 2026-10-22.
.claude/skills/view-chain-layout/SKILL.mdbyte-identical to the core's corrected copy (a layout fix is whitespace-only by construction, not by a check). Merge together with abap2UI5/abap2UI5, samples-controls and samples-stack on the same branch name; the core'scheck:sharedis red until all four carry it.@abap2ui5/linter/linter-render^0.9.0; the one new finding (omit-initial-drops-falseon app 507) is the pitfall that sample shows on purpose and carries a one-line disable with the reason.z2ui5_cl_smp_app_061built its row type from the framework's internalZ2UI5_T_01under the corpus's onlynon-released-apidisable; it now usesSYST.npm run checkgreen, abap2ui5lint 141 files, 0 failing.Generated by Claude Code