Skip to content

Update repository references for rename to ably-pubsub-python - #682

Draft
umair-ably wants to merge 1 commit into
mainfrom
pubsub-split/rename-references
Draft

Update repository references for rename to ably-pubsub-python#682
umair-ably wants to merge 1 commit into
mainfrom
pubsub-split/rename-references

Conversation

@umair-ably

Copy link
Copy Markdown

Why

PDR-091b renames this repository ably-pythonably-pubsub-python. This PR updates every internal reference tied to the repository's identity so it can land in the rename freeze window.

What changed

  • .github/workflows/features.ymlrepository-name: ably-pythonably-pubsub-python. This selects the per-repo IAM role assumed via OIDC for the features-report upload; the new ably-sdk-builds-ably-pubsub-python role is already provisioned (infrastructure#13005, merged 2026-09-01).
  • pyproject.toml[project.urls] Repository.
  • README.md — license badge and link, CHANGELOG link, GitHub Issues link.
  • LONG_DESCRIPTION.rst — usage-examples link (rendered on PyPI).
  • CONTRIBUTING.md — title/intro, both release-workflow links, and the github_changelog_generator -p project flag (3 occurrences).
  • .ably/capabilities.yaml — PR link.
  • .claude/skills/release/SKILL.md — CHANGELOG link templates, which pointed at ably-java; now ably-pubsub-python.

uv run ruff check passes and pytest test/unit is green (75 passed).

⚠️ Merge only in the rename freeze window

Merge immediately after the repository is renamed, not before. Merging early breaks two things:

  • features.yml — the new IAM role's OIDC trust is bound to repo:ably/ably-pubsub-python, so the subject won't match until the rename happens, and the credentials step fails (the upload failure mode is otherwise silent, so verify the upload actually lands post-merge).
  • The README license badge, which resolves against a repository name that doesn't exist yet.

Conversely, once the rename happens the old repository-name stops matching, so this is a same-window change in both directions.

What this PR deliberately does not do

  • The ably-python/<version> Ably-Agent identifier (ably/http/httputils.py) — a registered agent identifier, not a repository reference. The legacy ably distribution must keep sending it; the family rename to ably-pubsub-python happens only in the new major on integration/v4 (plan step 14b).
  • Historical CHANGELOG.md / UPDATING.md entries and issue links in tests and code comments — GitHub's rename redirect covers all of them, and rewriting history entries is churn.
  • PyPI / TestPyPI trusted-publisher rebinds — the legacy ably project's publisher is bound to ably/ably-python and must be re-pointed registry-side, plus the pending publishers for the new distributions. Registry work, not repo work; see plan steps 16/17/25.

Mirrors ably-ruby#457.

🤖 Generated with Claude Code

Updates every reference tied to this repository's identity ahead of the
rename `ably-python` -> `ably-pubsub-python` (PDR-091b).

`.github/workflows/features.yml`'s `repository-name` is not cosmetic: it
selects the per-repo IAM role assumed via OIDC when uploading the
features report. The new `ably-sdk-builds-ably-pubsub-python` role is
already provisioned (infrastructure#13005, merged 2026-09-01) and its
trust policy is bound to the new repository name, so this change only
works once the repo has been renamed.

Also fixes the `/release` skill's CHANGELOG link templates, which
pointed at ably-java.

Deliberately unchanged: the `ably-python/<version>` Ably-Agent
identifier (a registered identifier, not a repository reference — it
changes only in the new major), historical CHANGELOG entries, and issue
links in tests and comments — GitHub's rename redirect covers those.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@umair-ably

Copy link
Copy Markdown
Author

CI note for reviewers:

  • build / build (features.yml) fails with Not authorized to perform sts:AssumeRoleWithWebIdentity. Expected: this PR points repository-name at ably-pubsub-python, whose IAM role (infrastructure#13005) trusts an OIDC subject for ably/ably-pubsub-python. The repo is still ably/ably-python, so the assume-role is refused. This is the concrete reason the PR must merge only in the rename freeze window; it will go green once the repo is renamed.
  • check (3.13): single failure in realtimepresence_test.py::test_presence_message_action[json], a sandbox flake. This PR changes no code under ably/; the other six Python versions passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant